Repository navigation
fix(msi): mark POWERSHELLEXE as secure property - #1202
Open
PowershellKnut wants to merge 1 commit into
Open
PowershellKnut wants to merge 1 commit into
PowershellKnut wants to merge 1 commit into
Conversation
The PowerShell registry search runs in the client-side UI sequence.
Since POWERSHELLEXE was not listed in SecureCustomProperties, the
elevated server process dropped it ("Ignoring disallowed property"),
skipped AppSearch as already done, and the launch condition failed with
"You must have PowerShell 5.0 or higher" on interactive installs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
Secure="yes"to thePOWERSHELLEXEproperty inSources/Wix/build.wxs.On an interactive install, AppSearch runs in the client UI sequence and sets
POWERSHELLEXE.Because the property was not in
SecureCustomProperties, the elevated server process discardedit ("Ignoring disallowed property POWERSHELLEXE") and skipped AppSearch because it had already
run on the client. The launch condition then failed with "You must have PowerShell 5.0 or higher".
The value is also used by the deferred
CA_PowerShell_Install/CA_PowerShell_Uninstallactions,so it must reach the server side.
This is the same pattern already used for the other public properties (
NOTIFICATIONLEVEL,USERCONTEXT, ...).Mandatory Checklist
Related Issue
Fixes #1201
🤖 Generated with Claude Code