Repository navigation
Add turbo-modals and soft-destroyable skills; align turbo-fetch with rolemodel_rails - #60
Open
OutlawAndy wants to merge 4 commits into
Open
OutlawAndy wants to merge 4 commits into
OutlawAndy wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two moderate turbo-fetch issues and documentation inaccuracies remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (4)
What changed in this PR
Adds generator-aligned Rails skills for Turbo modals, soft deletion, and Turbo Forms.
Changes:
- Added
turbo-modalsandsoft-destroyable. - Updated
turbo-fetchto useturbo-form. - Registered skills in
README.mdandAGENTS.md.
| File | Summary |
|---|---|
skills/turbo-modals/SKILL.md |
Adds modal and panel guidance; three nit findings remain. |
skills/soft-destroyable/SKILL.md |
Adds soft-delete guidance; two nit findings remain. |
skills/turbo-fetch/SKILL.md |
Aligns Turbo Form documentation; two moderate findings remain. |
README.md |
Updates the skill catalog. |
AGENTS.md |
Documents the new skills. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
6 of 7 tasks
Member
Author
|
Companion: RoleModel/rolemodel_rails#208 |
OutlawAndy
added a commit
that referenced
this pull request
Sep 29, 2026
- form-auto-save: use the generator-installed turbo-form controller and helper - turbo-modals: panels render into their own frame; fix invalid Slim comment - soft-destroyable: state the UnknownAttributeError when _soft_destroy= is missing Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The rolemodel_rails generators are starting to install these skills into apps alongside the code they generate, so each skill has to match what its generator installs. - turbo-modals: new, covers the modal/panel pattern from rolemodel:turbo:modals - soft-destroyable: new, covers the SoftDestroyable concern and shared example Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- turbo-modals: panels render into their own frame; fix invalid Slim comment - soft-destroyable: state the UnknownAttributeError when _soft_destroy= is missing Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
OutlawAndy
added a commit
that referenced
this pull request
Sep 29, 2026
- turbo-modals: panels render into their own frame; fix invalid Slim comment - soft-destroyable: state the UnknownAttributeError when _soft_destroy= is missing Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
OutlawAndy
force-pushed
the
rolemodel-rails-generator-skills
branch
from
September 29, 2026 17:23
108cdc7 to
8326ca7
Compare
justwiebe
force-pushed
the
rolemodel-rails-generator-skills
branch
from
October 7, 2026 21:00
8326ca7 to
eb8bf0a
Compare
…ator-skills # Conflicts: # AGENTS.md # README.md
rails-conventions prescribes 'Successfully Created Widget'. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rolemodel_rails generators will install these skills into apps alongside the code they generate (companion PR: RoleModel/rolemodel_rails — install-agent-skills), so each skill has to match what its generator actually installs.
turbo-fetchhad drifted: it told agents to hand-write aturbo-fetchcontroller, but the generator installs the same controller registered asturbo-form.What Changed
turbo-modalsskill for the modal/panel pattern fromrolemodel:turbo:modals(422 on errors, redirect on success,form:on footer buttons, never thelayoutclass method)soft-destroyableskill for theSoftDestroyableconcern (no default scopes, cascade/restore semantics, shared example)turbo-fetchnow uses the generator'sturbo-formidentifier, points to the generator instead of inlining the controller, fixes the claimed URL default (there isn't one), and documentsexpect_turbo_form_request. The skill name is unchanged so existing installs keep working. It also notes that older apps may registerturbo-fetch.Screenshots
N/A — no UI changes
Pre-merge
README.mdandAGENTS.md? Any new, renamed, or removed skill needs a row in the README table and a bullet in AGENTS.md. Check the box or replace it withN/Aif this PR touches no skill.🤖 Generated with Claude Code