Repository navigation
Conversation
…tings The workspace no longer prompts anyone opening the repo to install editor extensions, and its settings keep only what the editor reads natively plus pytest discovery. Linting, formatting and type checks run from the command line and the pre-commit hook.
Contributor
|
Change classification: normal — platform or application code changed. A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The |
Member
Author
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 15s —— View job PR review: drop VS Code extension recommendationsVerdict: approve-worthy, no blocking issues.
Findings
Nits (optional)
I did not run tests, since this is editor configuration only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the workspace's editor-extension recommendations and the settings that only did anything with those extensions installed. The repo no longer prompts anyone who opens it to install third-party editor extensions, which narrows the supply-chain surface for contributors; linting, formatting and type checks already run from the command line and the pre-commit hook.
Changes
.vscode/extensions.json(deleted).vscode/settings.jsonpython.autoComplete.extraPathsandruff.exclude.python.testing.*).pytestArgsis now just["tests"]: the two--ignorearguments pointed outsidetests.files.excludeandsearch.exclude, minus entries for paths that do not exist in this repo (node_modules,__mocks__,arelle/EDGAR).Worth knowing as a reviewer: the editor no longer formats Python on save from workspace settings, so unformatted files are caught by the pre-commit check (
ruff format --check) and fixed withjust format.Breaking Changes
None
Testing
Editor configuration only; no application code changed. The pre-commit hook ran on the commit and passed (ruff check, ruff format check, basedpyright, cf-lint).
just test-allwas not run.Certification
🤖 Generated with Claude Code