Skip to content

chore(vscode): drop extension recommendations and extension-bound settings - #2018

Open
jfrench9 wants to merge 1 commit into
mainfrom
chore/remove-vscode-extension-recommendations
Open

jfrench9 wants to merge 1 commit into
mainfrom
chore/remove-vscode-extension-recommendations

Conversation

@jfrench9

Copy link
Copy Markdown
Member

Summary

Removes the workspace's editor-extension recommendations and the settings that only did anything with those extensions installed. The repo no longer prompts anyone who opens it to install third-party editor extensions, which narrows the supply-chain surface for contributors; linting, formatting and type checks already run from the command line and the pre-commit hook.

Changes

.vscode/extensions.json (deleted)

  • Dropped all 23 recommendations. Nothing else in the repo referenced the file.

.vscode/settings.json

  • Removed the extension-bound settings: the Prettier and Ruff default formatters with format-on-save, the ESLint fix-on-save action, the Tailwind class regex, python.autoComplete.extraPaths and ruff.exclude.
  • Kept pytest discovery (python.testing.*). pytestArgs is now just ["tests"]: the two --ignore arguments pointed outside tests.
  • Kept files.exclude and search.exclude, minus entries for paths that do not exist in this repo (node_modules, __mocks__, arelle/EDGAR).

Worth knowing as a reviewer: the editor no longer formats Python on save from workspace settings, so unformatted files are caught by the pre-commit check (ruff format --check) and fixed with just format.

Breaking Changes

None

Testing

Editor configuration only; no application code changed. The pre-commit hook ran on the commit and passed (ruff check, ruff format check, basedpyright, cf-lint). just test-all was not run.

Certification

  • I have the right to submit this work under the Apache 2.0 license, and do so. Where any part of it is owned by my employer, I have their permission.

🤖 Generated with Claude Code

…tings

The workspace no longer prompts anyone opening the repo to install
editor extensions, and its settings keep only what the editor reads
natively plus pytest discovery. Linting, formatting and type checks
run from the command line and the pre-commit hook.
@github-actions github-actions Bot added the change:normal Normal change: automated review documented on the pull request before merge label Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Change classification: normal — platform or application code changed.

A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The change-classification job requests that review and passes once it has been posted. Recorded by the change-classification job.

@jfrench9

Copy link
Copy Markdown
Member Author

@claude please review this PR

@claude

claude Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Claude finished @jfrench9's task in 15s —— View job


PR review: drop VS Code extension recommendations

Verdict: approve-worthy, no blocking issues.

  • Read the diff and the deleted extensions.json
  • Checked for references to the removed file/settings
  • Verified the trimmed paths and ignore args

Findings

  • .vscode/extensions.json deletion: Nothing in the repo references it. The only .vscode hit is the pyproject.toml ruff exclude, which is unaffected.
  • pytestArgs: ["tests"] is fine. The removed --ignore=robosystems/adapters/sec/arelle* paths sit outside tests, so they were no-ops. pytest.ini already sets testpaths = tests. tests/arelle/ is a real directory and stays collected, as it was before.
  • files.exclude / search.exclude: The removed entries (node_modules, __mocks__, arelle/EDGAR) are stale. robosystems/adapters/sec/arelle/ exists (it contains bundles), and the broader arelle/** search exclude is kept, so nothing is lost.
  • ruff.exclude removal: This is harmless. The ruff extension reads [tool.ruff] exclude from pyproject.toml, which already covers robosystems/adapters/sec/arelle.
  • Format-on-save: This is the one behavioral change, and the PR description already calls it out. Contributors who still have Ruff installed will lose workspace-enforced format-on-save. The pre-commit ruff format --check catches unformatted files, so it is a convenience loss only.

Nits (optional)

  • Without python.analysis.extraPaths / python.autoComplete.extraPaths, Pylance-style import resolution may degrade if anyone uses it. The uv venv and robosystems package layout should resolve fine without it, so I would not add it back.
  • Contributors who want format-on-save can set it in their user settings. A line in the contributing docs would help, but it is not necessary.

I did not run tests, since this is editor configuration only.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:normal Normal change: automated review documented on the pull request before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant