Repository navigation
feat(inbox): label the needs-review skip reason in a batch approve - #553
Merged
Merged
Conversation
Contributor
|
Change classification: normal — platform or application code changed. A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The |
Member
Author
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 11s —— View job Review: PR #553 — label the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch approve can now leave a line alone because its suggestion carries a caution (an amount far above that counterparty's usual). The inbox names that reason in the batch result instead of showing the raw code.
Changes
ledger/inbox/content.tsx): a label for theneeds_reviewskip reason: "unusual for this counterparty; open it and choose".Deploy Notes
Reads a skip reason added in the RoboSystems API after v1.22.3. Against an older API the label is never used.
Testing
🤖 Generated with Claude Code