Repository navigation
Fix 42 vsbq engine path - #126
Closed
Datamagician10 wants to merge 2 commits into
Closed
Datamagician10 wants to merge 2 commits into
Datamagician10 wants to merge 2 commits into
Conversation
7595daf renamed the CLI target to zigquery-cli, but vsbq.py still invoked ./zig-out/bin/zigquery, so it silently compared BigQuery against whatever stale binary happened to be installed. Fixes Recidiviz#42.
A missing binary used to surface as one error verdict per case, after a run that looked like it had measured something. Resolve the binary once in main() and exit loudly instead, naming the build command. Part of Recidiviz#42.
Member
|
Thanks for the PR! Closing as this has already been fixed in #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.