Repository navigation
fix: round numerics to nearest float64 to match bigquery - #107
Merged
Merged
Conversation
ohaibbq
requested review from
a team,
colincadams,
emilyemilyemilyemilyemilyemily,
incidentist and
klickyfan
November 2, 2026 18:03
incidentist
approved these changes
Nov 3, 2026
codec perf: ┌─────────────────────────────┬────────┬───────┐ │ Input │ Before │ After │ ├─────────────────────────────┼────────┼───────┤ │ NUMERIC, 1–12 digits │ ~4 ns │ ~4 ns │ ├─────────────────────────────┼────────┼───────┤ │ NUMERIC, up to 38 digits │ 7 ns │ 24 ns │ ├─────────────────────────────┼────────┼───────┤ │ BIGNUMERIC, up to 76 digits │ 11 ns │ 35 ns │ └─────────────────────────────┴────────┴───────┘
ohaibbq
force-pushed
the
dan/numeric-float64-rounding
branch
from
November 3, 2026 22:08
61e428e to
9d5a041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codec perf:
Stack created with GitHub Stacks CLI • Give Feedback 💬