Repository navigation
fix: declare in pyproject.toml too that we dropped py 3.9 - #85
Merged
Merged
Conversation
joanise
force-pushed
the
dev.ej/drop-py39
branch
from
October 28, 2026 19:52
3a09ded to
de0b014
Compare
dhdaines
approved these changes
Oct 29, 2026
dhdaines
left a comment
dhdaines
left a comment
Contributor
There was a problem hiding this comment.
Well, technically we still do support Python 3.9, but we can't verify it without tests, so I'm okay with this...
Member
Author
Yeah, it's going to keep working for a while, and then it won't and we won't notice it. I prefer forcing the use of <=0.6.7 with older Pythons, because we know for sure that that will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
One more small thing: if we're going to drop 3.9 from CI and cibuildwheels, we should declare that explicitly in pyproject.toml
Fixes?
an inconsistency
Priority?
before publishing 0.6.8
Confidence?
high