Skip to content

feat[drivers][block]: fix printf format type mismatches - #11809

Open
wdfk-prog wants to merge 1 commit into
RT-Thread:masterfrom
wdfk-prog:feat/drivers/block
Open

feat[drivers][block]: fix printf format type mismatches#11809
wdfk-prog wants to merge 1 commit into
RT-Thread:masterfrom
wdfk-prog:feat/drivers/block

Conversation

@wdfk-prog

@wdfk-prog wdfk-prog commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

components/drivers/block/blk_partition.c 中部分日志格式符与实际参数类型不匹配。

在部分 32 位 GCC/newlib ABI 下，rt_uint32_t 和 rt_size_t
对应 unsigned long，但当前代码使用 %u 输出这些值，因此启用
-Wformat 后会出现类型不匹配告警。

另外，partno 本身的类型为 int，原代码却使用 %u 输出。

典型告警包括：

format '%u' expects argument of type 'unsigned int',
but argument has type 'rt_uint32_t'

你的解决方案是什么 (what is your solution)

调整 block partition 日志的格式符和参数类型：

  • partno 使用 %d
  • partition offset、count 和容量相关值统一显式转换为
    unsigned long 后使用 %lu
  • KB/MB/GB 输出中的整数部分和小数部分使用与参数类型匹配的格式符
  • 修正错误日志中 start 和 count 的格式参数

本次修改仅涉及日志输出的格式符和显式类型转换，
不修改分区探测、分区计算、设备注册或其他运行逻辑。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

[请填写实际验证 BSP]

  • .config:

[请填写触发 block partition 驱动编译所使用的实际 .config 配置]

  • action:

[请填写你自己仓库对应 PR 分支的 RT-Thread Action 编译链接]

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@wdfk-prog
feat[drivers][block]: fix printf format type mismatches
03de2e0 
Fix format specifier mismatches in blk_partition.c by using the
appropriate integer formats and explicit casts.

This removes -Wformat warnings on platforms where rt_uint32_t and
rt_size_t are represented as unsigned long.
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支（通常为 master）
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 feat/drivers/block
    Enter PR branch feat/drivers/block in the branch field
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 feat/drivers/block 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat/drivers/block branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/block/blk_partition.c

📊 Current Review Status (Last Updated: 2026-09-17 11:50 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

nuvoton-m487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wdfk-prog