Repository navigation
Users/gilbelee/fix ibv probe crash - #364
Merged
Merged
Conversation
gilbertlee-amd
commented
Oct 22, 2026
gilbertlee-amd
commented
Collaborator
- Isolate IBV device probing in a forked child to survive buggy ibverbs providers
- Default A2A_DIRECT=0 on MI4XX for the a2a preset
… providers TransferBench::GetIbvDeviceList() calls ibv_open_device()/ibv_query_device()/ ibv_query_port() on every listed RDMA device during startup topology detection, even with no args. On a host with a buggy vendor ibverbs provider plugin, this crashed with SIGSEGV inside the provider's device-open path before TransferBench printed anything. Each device is now probed in a forked child process; if the child crashes or exits non-zero, the parent reports that device as inactive with a warning instead of dying itself. Other devices are unaffected. Bump version to 1.71.01 and update CHANGELOG. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
On MI4XX (gfx1250) hardware, full all-to-all lets DPX route transfers more intuitively than restricting to directly-connected XGMI links, so default A2A_DIRECT=0 there (still 1 on other hardware, overridable via the env var). Applies to both the a2a and a2asweep presets, computed once in EnvVars alongside the existing per-arch GFX_UNROLL default. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AtlantaPepsi
approved these changes
Oct 22, 2026
Keeps the version fallback in sync with the v1.71.01 CHANGELOG entry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.