Repository navigation
fix(actions): allow empty nullable enums in action forms - #34
Merged
Merged
Conversation
MathiasReichardt
commented
Oct 5, 2026
Contributor
- treat enum containing null as nullable, e.g. {"enum": [..., null]} without type
- treat oneOf/anyOf with a null branch as nullable
- skip the non-null check for fields without type, enum or const, e.g. {}
- mark non-nullable fields as required, so the asterisk shows why Submit is disabled
- add form level tests that run each schema shape through the schema simplifier
- regression from Add file upload action parameters #32, which enforced non-null on every field and disabled Submit
- treat enum containing null as nullable, e.g. {"enum": [..., null]} without type
- treat oneOf/anyOf with a null branch as nullable
- skip the non-null check for fields without type, enum or const, e.g. {}
- mark non-nullable fields as required, so the asterisk shows why Submit is
disabled
- add form level tests that run each schema shape through the schema simplifier
- regression from #32, which enforced non-null on every field and disabled Submit
park-jasper
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.