ci: run the cross-port drift checks on the launcher conformance lane - #2
Merged
Merged
Conversation
The conformance lanes compare this port to the reference over the wire, and that is the one comparison which cannot see a port drifting in what it *says about itself*. Four ports described vgi_rpc.Reflection.v1 as having zero methods and six logged six different wrong protocol_hash values, all with green suites. describe_diff and identity_consistency are the checks that found it, and until now they ran only by hand on a maintainer's machine. They ride the launcher lane rather than a job of their own for the same reason the access-log validator does: describe_diff spawns the worker on stdio and talks to it over a pipe, which is this lane's transport, and the lane already clones the reference and installs its conformance extras. The reference clone moves from RUNNER_TEMP to a sibling of this checkout because the tools resolve a port as <repos>/vgi-rpc-<name>; $GITHUB_WORKSPACE's parent already holds this repo under exactly that name, so no copy and no symlink are needed and Gradle keeps running in the real workspace. The checks run before the suite. They cost seconds, and a hash diff naming the field that differs is a better first answer than a thousand red test results. Deliberately unpinned. VGI_RPC_PYTHON_REV stays scoped to the Iroh lane, where this port is the client and the pinned revision is a party to the wire contract. Here the reference is the yardstick, and a pinned yardstick is how that lane reported green for eleven days against a stale reference. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K2bAuCcTPfo6qEGkN8GoL3
rustyconover
force-pushed
the
ci-cross-port-drift
branch
from
September 16, 2026 16:08
ffdf326 to
dbdfec5
Compare
rustyconover
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
describe_diff --only javaandidentity_consistency --only javato theconformance / launcher (pipe/unix, no shm)lane, before the wire suite.Verified by observation, not by assumption: run 35118956342 carried a deliberate
echo_int(long value)->echo_int(long number)perturbation and the new stepfailed with
The perturbation was then reverted; run 35119974092 is green on all 8 jobs, with
the checks reporting
AGREEDon both frozen digests and the identity auditnaming 25 Java identity files.
The reference is cloned from
mainwith no pin.VGI_RPC_PYTHON_REVstaysscoped to the Iroh lane, where this port is the client and the pinned revision is
a party to the wire contract.
🤖 Generated with Claude Code
https://claude.ai/code/session_01K2bAuCcTPfo6qEGkN8GoL3