Round-2 consistency pass: espace de nommage and renvoyer edition-wide, plus two hand-ports - #81
Merged
Merged
Conversation
…, plus two hand-ports Brings the rest of the edition into line with the editor's round-2 rulings (#77, #78, #80), following the #26 pattern: - « espace de noms » -> « espace de nommage » (#80, per the official French Python docs): oop_intro.md:398, scipy.md:88, python_oop.md:262/296. The adjective at oop_intro.md:398 stays « intégré » pending the editor's built-in ruling. - « retourner » -> « renvoyer » for returned values (#80): pandas_panel.md:466/475/479/517/523, polars.md:546. - functions.md:348: the English "standard normals" are draws, so « variables normales centrées réduites », not « lois ». Hand-ports: - numpy.md:1296: `discreteRV` -> `DiscreteRV`, the QuantEcon/lecture-python-programming#604 edit that never arrived (the numpy.md sync fails structural parity until the source's duplicated {index} is removed). - sympy.md: repair the garbled seed anchor `(sympy=` and drop the duplicate `(sympy)=` added before the title, matching the source pre-title. No typography changes (apply.mjs --dry-run: 0/27). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
There is a verified typo in lectures/python_oop.md (__init_ vs __init__) that should be corrected before merging.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR applies an edition-wide terminology consistency pass (per prior merged rulings) and includes two small hand-ports to align this edition with upstream/source structure.
Changes:
- Replace « espace de noms » with « espace de nommage » in remaining targeted chapters.
- Replace « retourner » with « renvoyer » when describing functions/methods returning values.
- Hand-port fixes: correct the SymPy anchor placement and update a NumPy class name reference (
DiscreteRV).
| File | Description |
|---|---|
| lectures/sympy.md | Fixes/normalizes the (sympy)= anchor placement by removing the garbled/duplicate target. |
| lectures/scipy.md | Updates namespace terminology in a SciPy note block to « espace de nommage ». |
| lectures/python_oop.md | Updates namespace terminology to « espace de nommage » in OOP constructor/instance storage explanations. |
| lectures/polars.md | Updates “returns” terminology to « renvoie » in the lazy API explanation. |
| lectures/pandas_panel.md | Updates multiple “returns” occurrences to « renvoyer/renverra » in the groupby/panel exercise text. |
| lectures/oop_intro.md | Updates built-in namespace phrasing to « espace de nommage intégré ». |
| lectures/numpy.md | Updates class reference from discreteRV to DiscreteRV for consistency with the defined class name. |
| lectures/functions.md | Clarifies wording from “standard normals” as distributions to “variables normales centrées réduites” as draws/variables. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-81--verdant-toffee-3261a8.netlify.app Commit: 📚 Changed LecturesBuild Info
|
A one-character typo carried over from the English source (QuantEcon/lecture-python-programming python_oop.md:243, listed in QuantEcon/lecture-python-programming#633). Raised by Copilot review. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brings the rest of the edition into line with Emile's round-2 rulings (#77, #78, #80 — merged today), following the #26 pattern, plus two small hand-ports. 13 lines in 8 files; no wording changes beyond the ones listed.
Terminology, per the rulings
oop_intro.md:398,scipy.md:88,python_oop.md:262,python_oop.md:296oop_intro.md:398stays « intégré » until the built-in question on #80 is answered.pandas_panel.md:466/475/479/517/523,polars.md:546functions.md:348Hand-ports
numpy.md:1296:discreteRV→DiscreteRV— an edit from FIX: seven source-side defects in python_by_example, functions, numpy and pandas lecture-python-programming#604 that never reached this edition, because everynumpy.mdsync has failed structural parity (the source's duplicated{index}, now proposed for removal in [numpy] Remove the duplicated {index} directive under Matrix Multiplication lecture-python-programming#632).sympy.md: repairs the garbled seed anchor(sympy=(live as a stray paragraph) and drops the duplicate(sympy)=added before the title in Restore the (sympy)= target anchor dropped by the seed translation #16, so the pre-title matches the source.This pairs with the French glossary v1.2 (QuantEcon/action-translation#328, which pins Namespace → Espace de nommage): merging this first means the release does not leave the edition inconsistent with its own glossary.
apply.mjs --dry-runreports no typography changes (0/27).@Honaminto — for information; nothing here needs your time unless you disagree with a change.
🤖 Generated with Claude Code