Repository navigation
Conversation
…uliWord. Forgot to include enum of LossySite in loss.rs in ppvm-traits-2
|
david-pl
requested changes
Oct 16, 2026
david-pl
left a comment
david-pl
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good, and thanks for keeping the scope small! There are some copy & paste errors from the standard Pauli word, which don't properly handle caches or lbits.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this crate can be quite complicated, this is just PR 1 of incremental merges to support lossy-pauli-word-2. This patch does the following:
Part of the effort to refactoring #204