Conversation
…alization of dynamif mutable Params
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4048 +/- ##
==========================================
+ Coverage 89.96% 90.13% +0.16%
==========================================
Files 917 917
Lines 109282 109298 +16
==========================================
+ Hits 98311 98511 +200
+ Misses 10971 10787 -184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4009; supersedes #4030
Summary/Motivation:
#4009 identified a bug where some Params were not being correctly initialized when instantiated outside of
Param.construct(). While Params with default values were being correctly initialized,_getitem_when_not_presentwas not checking if the initializer (rule=/initialize=) could have provided a value (which is the case for constant initializers and initializers that call out to general functions).This PR resolves the issue by also checking the rule for initial values when creating / returning param values outside of
construct()Changes proposed in this PR:
default=handling to leverage theInitializerinfrastructure_getitem_when_not_presentto check the rule before falling back on the default.AI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: