Repository navigation
Update PyROS Uncertainty Set Implementations - #4043
Open
shermanjasonaf wants to merge 26 commits into
Open
shermanjasonaf wants to merge 26 commits into
shermanjasonaf wants to merge 26 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR makes changes to the PyROS
UncertaintySetclass and most of the pre-implemented concrete subclasses included in the PyROS uncertainty sets module.Changes proposed in this PR:
1. Add a generic
scenariosattribute to theUncertaintySetbase classThis attribute is designed to return the points comprising the set represented by an
UncertaintySetinstance, if the set is known to be discrete (i.e., of geometryGeometry.DISCRETE_SCENARIOS).2. Update the pre-implemented concrete
UncertaintySetsubclassesAxisAlignedEllipsoidalSetparameter_bounds.centerandhalf_lengthssetters.BudgetSetbudget_rhs_vecandbudget_membership_matsetters.CardinalitySetorigin,negative_deviation, andpositive_deviationsetters.CartesianProductSetCartesianProductSet(*args)). Deprecate the constructor interface of AddCartesianProductSetto PyROS #3927.DiscreteScenarioSetscenariossetter.EllipsoidalSetparameter_bounds.centerandshape_matrixsetters.IntersectionSetIntersectionSet(*args)) rather than by keyword. Deprecate keyword-based operand specification. Thus, the newIntersectionSetconstructor is designed to more closely match that ofCartesianProductSet.scenariosproperty (introduced in Fix PyROSIntersectionSetImplementation #3786) for improved performance.is_nonempty()for cases where the intersection is discrete.validate()andset_as_constraint()methods.all_setssetter.PolyhedralSetcoefficients_matandrhs_vecsetters.3. Update the documentation of the
GeometryenumThis change clarifies the significance of the
Geometryenum and the attributeUncertaintySet.geometry.AI-Use Disclosure
The calls to SciPy Cholesky factorization-based routines, used in the updated
EllipsoidalSetimplementation, are based on context-independent AI-generated code and have been adapted by me before committing.AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: