Skip to content

feat(assessment): Increase Dataset Row Fetch Limit #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vprashrex merged 4 commits into from
Sep 28, 2026
+2 −2
Merged

feat(assessment): Increase Dataset Row Fetch Limit #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
262fbb0
feat(Assessment): Dataset Update limit for preview rows to 2000 in ge…
vprashrex Sep 21, 2026
071f1ad
Merge branch 'main' into chore/bump-dataset-validation-limit
vprashrex Sep 22, 2026
14e4431
Merge branch 'main' into chore/bump-dataset-validation-limit
vprashrex Sep 22, 2026
64970ef
Merge branch 'main' into chore/bump-dataset-validation-limit
Ayush8923 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/app/api/docs/assessment/get_dataset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ Get a single assessment dataset by ID.

Optionally include a signed URL to download the original uploaded file.

Pass `limit_rows=N` (1-100) to additionally include a lightweight preview
Pass `limit_rows=N` (1-2000) to additionally include a lightweight preview
of the dataset's column headers and the first N data rows. When omitted,
the underlying file is not fetched and the response stays small.
2 changes: 1 addition & 1 deletion backend/app/api/routes/assessment/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def get_dataset(
int | None,
Query(
ge=1,
le=100,
le=2000,

@Ayush8923 Ayush8923 Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fetching 2000 rows at once too much? how much load would this put on the system, and could it cause slowness in other APIs? have we checked all of these aspects?

@vprashrex vprashrex Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this doesn't add extra load or affect other APIs, the file is already fetched in full regardless of the limit value, this param only controls how many rows get returned in this one preview response. It's isolated to this endpoint.

description=(
"If set, fetch the underlying file and include a preview of the "
"first N data rows plus column headers. Skip to avoid the file "
Expand Down
Loading