Conversation
Collaborator
|
Thanks for adding this coverage. We recreated the tests in our internal monorepo, including cleanup of the temporary directory, and they will reach this mirror in a future sync. This repository is read-only, so we're closing the PR here. We appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/commands/transactions.ts(thetransactions receiptcommand) had 0% test coverage, found vianpx vitest run --coverage. It reads a JSON request body from--request, and had no tests for the success path or for a missing/invalid file.Solution
Adds
test/commands/transactions.test.tscovering:--requestparsing and POST to/api/v2/transactions/receipt--requestfile--requestfile--requestoptionFollows the same temp-file pattern already used in
test/commands/orders.test.tsandtest/parse.test.ts(mkdtempSync, not aDate.now()suffix, to avoid path collisions on concurrent runs). Coverage for this file goes from 0% to 100% statements/lines.