Repository navigation
Fix release stages ignoring native command failures - #34
Merged
Merged
Conversation
Add native-process regressions for every affected validation and package-push stage before adding immediate exit checks. Preserve the issue #19 publishing gates. Co-authored-by: Codex <codex@openai.com>
AGiorgetti
marked this pull request as ready for review
October 5, 2026 14:28
Register the process fixture in both solution formats so clean Release builds produce the native apphost used by workflow regression tests. Co-authored-by: Codex <codex@openai.com>
AGiorgetti
marked this pull request as draft
October 5, 2026 14:37
AGiorgetti
marked this pull request as ready for review
October 7, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Release validation and early NuGet push failures could be hidden when later native commands reset LASTEXITCODE. Check each native exit immediately and report its operation or package before continuing.
Covers GitVersion, Windows toolchain/tests, both solution formats, every pack/API check/push, consumer restore/run, both trimmed execution branches, and AOT publish. The native test fixture is included in both solutions so clean builds use the requested configuration. Preserves #19's publishing gates, production approval, artifact dependencies, and the local helper's existing guards. Changelog entry is under Unreleased/Fixes.
Fixes #20.
Verification
Ready for human review; retained as draft. No real NuGet push, release, tag push, workflow dispatch, or merge was performed.