Repository navigation
ci: release environment and secrets check - #74
Conversation
… check The release, winget and chocolatey jobs run in the 'release' environment, so they wait for the maintainer's approval and read the environment secrets. 'Check release secrets' is a manual, publish-nothing workflow: inside the environment it confirms the three secrets exist and that the winget token is valid and owned by WINGET_FORK_OWNER; a second job outside the environment shows whether the repository-level copies still exist.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37db3691c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| CHOCOLATEY_API_KEY: ${{ secrets.CHOCOLATEY_API_KEY }} | ||
| WINGET_GITHUB_TOKEN: ${{ secrets.WINGET_GITHUB_TOKEN }} | ||
| WINGET_FORK_OWNER: ${{ secrets.WINGET_FORK_OWNER }} |
There was a problem hiding this comment.
While the repository-level copies still exist, this job has no protected environment yet injects all three credentials. Any user with repository write access can manually dispatch a workflow_dispatch workflow against a selected branch (GitHub Docs); such a user can alter this job on their branch to exfiltrate the Chocolatey key or winget token without obtaining the intended release-environment approval. Delete the repository copies before exposing this workflow, or inspect secret metadata through an approved environment/API path instead of materializing the values in this unprotected job.
Useful? React with 👍 / 👎.
What
release,publish-wingetandpublish-chocolateyjobs run in the protectedreleaseenvironment: they wait for the maintainer's approval and read the environment secrets.check-release-secrets.yml): no permissions, publishes nothing, never prints a value.CHOCOLATEY_API_KEY,WINGET_GITHUB_TOKEN,WINGET_FORK_OWNERexist and that the winget token is valid and owned byWINGET_FORK_OWNER(read-onlyGET /user).Checks
release: required reviewer PrimeBuild-pc; deployments only frommainand tagsv*.*.*.