Repository navigation
test: pin the Python environment client's failure paths - #268
Merged
dmccoystephenson merged 1 commit intoNov 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline in the same session; not an independent review):
Findings:
Summary: a test-only PR, green on every CI job, consistent with #266 and #267. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/pin-environment-client-failure-paths
branch
November 12, 2026 06:24
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Stage B (unit-test expansion) cycle covering the Python client's
EnvironmentService(src/main/python/preponderous/viron/services/environmentService.py), following the entity client (#266) and the grid client (#267). Before this PR, the environment client's only failure test checked that aget_all_environmentsHTTP error escapes. Eighteen characterization tests are added tosrc/test/python/preponderous/viron/services/test_environmentService.py; no production code is changed.What is now pinned:
get_environment_by_id,get_environment_by_nameandget_environment_of_entity.create_environmentdoes not wrap its errors. A 400 reaches the caller asHTTPError(body never read) and aConnectionErroras itself.delete_environmentraises on a 404 and otherwise returnsTruewithout reading the status code. The server answers 204 (@ResponseStatus(HttpStatus.NO_CONTENT)).update_environment_namedoes not wrap its errors (404, 400,ConnectionError), matchingGridServiceand unlikeEntityService.update_entity_name. It returnsstatus_code == 200, so a 204 yieldsFalsewithout raising;EnvironmentController.updateEnvironmentNameis avoidhandler answering 200 today.get_all_environmentswas checked.TypeErroron anullbody, as in the grid client.Deferred issues
pom.xmlbuild-pipeline change beyond one cycle).Test plan
pytest -q(pytest 9.0.3): 165 passed (147 before, 18 new)python3 -m pytest -q(pytest 7.1.3, Python 3.8): 165 passedCIworkflow's Python jobs run this suite. No Java file is touched.No tracking issue — gap found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson