This repository was archived by the owner on Oct 19, 2026. It is now read-only.
Repository navigation
Conversation
Run the PyPI upload in the pypi environment with an OIDC token instead of the shared org-wide PYPI API token, and add a patch changelog entry so merging cuts a release through the new path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
marked this pull request as ready for review
October 12, 2026 14:38
The publish job ran make install (pip install -e .[dev]), and the dev extras pin policyengine-us==1.667.1, which is no longer on PyPI, so the job would fail before uploading. Building the wheel needs only the build tool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Closing without merging. policyengine-data is being retired instead of moved to PyPI trusted publishing: nothing in the PolicyEngine organization imports the package, and its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the PyPI upload in
.github/workflows/versioning.yamlfrom the shared org-widePYPIAPI token to PyPI trusted publishing (OIDC), and adds a patch changelog entry so merging this PR cuts a release through the new path.Changes to the
publish-to-pypijob:environment: pypi. Thepypienvironment already exists in this repo, limited tomain, so only runs onmaincan get a token PyPI will accept.permissions:withcontents: write(the job pushes the release tag via.github/publish-git-tag.sh, and job-level permissions replace the defaults) andid-token: write(needed to mint the OIDC token).user: __token__andpassword: ${{ secrets.PYPI }}frompypa/gh-action-pypi-publish. The action ignores OIDC while a password is passed.skip-existing: truestays.There are no other
secrets.PYPIuses in.github/.Release:
changelog_entry.yamlwithbump: patch.make changelog(yaml-changelogbuild-changelog+bump-version) turns this into 0.5.3 to 0.5.4. I checked this by running those commands on a copy of the branch files, which printedBumping from 0.5.3 to 0.5.4.Already broken, not fixed here:
.github/publish-git-tag.shcalls.github/fetch_version.py, which this repo doesn't have. So thePublish a git tagstep fails quietly (|| true), and no version tags have been pushed. This doesn't affect the PyPI upload, so I left it out of this PR.Publish job no longer installs the dev extras
The
[dev]extras pinpolicyengine-us==1.667.1, which has been removed from PyPI. The publish job ranmake install(pip install -e ".[dev]"), so it would fail before uploading. It now installs onlybuild, which is allpython -m buildneeds; a clean local build produces the wheel and sdist without the dev extras.The PR's
BuildandTestchecks still fail for the same reason. That failure is already onmain(CI has failed since 2026-04-28) and needs the test pin updated, which is left for a follow-up because newerpolicyengine-usversions may change test results.Before merging
Add a trusted publisher to the PyPI project
policyengine-data(Manage, then Publishing):PolicyEnginepolicyengine-dataversioning.yamlpypiIf this merges before the publisher exists, the upload fails with
invalid-publisher. Add the publisher, then re-run the failedPublish to PyPIjob.skip-existingmakes the re-run safe.Test plan
actionlinton the changed workflow: no findings, same as before the changeUpdate package versionrun'sPublish to PyPIjob uploads the new patch version using OIDC, and the version shows up on PyPI🤖 Generated with Claude Code