Repository navigation
Test every waterfill implementation against the Default one - #1638
Merged
Merged
Conversation
…mages The Waterfill kernel test was debug code. It was not registered, it only ran the implementation that the dispatch picks, and on x86 its reference read the binary matrix in the wrong layout. Add one test for each image and each SIMD or NEON implementation that the CPU supports, and compare each one with the Default 64x4 code. The images are from the CommandLineTests repo, and no image has a width or height that is a multiple of 64. Remove the 3-second timing loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gin890
force-pushed
the
fix-waterfill-test-reference
branch
from
October 21, 2026 05:22
adec888 to
2b8832a
Compare
Mysticial
approved these changes
Oct 21, 2026
Gin890
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Waterfill kernel test a real test. It now compares each SIMD and NEON waterfill implementation that the CPU supports with the Default implementation, on real images.
Before, the test was debug code. It was not registered, so CI did not run it. It tested only the implementation that the dispatch picks, and on x86 its reference read the binary matrix in the wrong layout.
Other changes:
The images are from the CommandLineTests repo. No image has a width or height that is a multiple of 64, so the test also checks the edge tiles. #1633 and #1554 also change this file, so one of them will need a small merge fix.
0 test files added, 1 test file changed:
Test results: all tests pass on all six CI runners. Each implementation runs on 3 images.
🤖 Generated with Claude Code