Repository navigation
AudioResampler: default to 32 taps, test taps 1-64 - #1608
Merged
Merged
Conversation
16 taps is a fairly aggressive truncation of the ideal sinc window; 32 taps is still cheap (the kernels are tap-count agnostic, the cost is one weight table row per tap) and measurably closer to the ideal filter for the sample rates this node targets.
Stream tests: a 1/2/3/4/5/8/32/48/63/64 sweep on the 1:1 combo (counts below the kernels' tap blocks are zero padded, odd counts exercise the unrolls' final partial group, wide counts stress the carry sizing and Kaiser window width) plus taps 1 and 64 on the strongest upsampling combo, where the tap count dominates the next block's input requirement. Dispatch tests: taps 1, 32, 64 across the kernel families. Default-kernel ULP tests: taps 1 and 64 alongside the standard 16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1572.
52 tests total (was 34), all passing locally on the NEON path; x64 kernel paths covered by CI.