Skip to content

Lazily import arrow types and models - #279

Merged
timkpaine merged 3 commits into
mainfrom
tkp/lazy-imports
Oct 17, 2026
Merged

timkpaine merged 3 commits into
mainfrom
tkp/lazy-imports

Conversation

@timkpaine

@timkpaine timkpaine commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

ccflow.arrow and ccflow.exttypes.arrow import pyarrow. Load their exports on first access through module getattr so importing ccflow no longer imports pyarrow.

ccflow.arrow and ccflow.exttypes.arrow import pyarrow. Load their exports on first access through module __getattr__ so importing ccflow no longer imports pyarrow.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
timkpaine marked this pull request as draft October 11, 2026 17:37
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.79%. Comparing base (70df911) to head (5742e53).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         190      190           
  Lines       21552    21562   +10     
  Branches     1413     1415    +2     
=======================================
+ Hits        20215    20225   +10     
  Misses       1062     1062           
  Partials      275      275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   2m 13s ⏱️ -43s
1 461 tests ±0  1 459 ✅ ±0  2 💤 ±0  0 ❌ ±0 
1 467 runs  ±0  1 465 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5742e53. ± Comparison against base commit 70df911.

♻️ This comment has been updated with latest results.

polars 2 does not preserve left frame row order in joins, so compare join results after sorting by the join key.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
timkpaine marked this pull request as ready for review October 15, 2026 19:47
@timkpaine
timkpaine merged commit ea121bd into main Oct 17, 2026
20 checks passed
@timkpaine
timkpaine deleted the tkp/lazy-imports branch October 17, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants