Repository navigation
Retire clean-room-review gate (sc-36368) - #5
Merged
Merged
Conversation
…on) (sc-36368) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inviscid
marked this pull request as ready for review
November 9, 2026 17:21
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
rad-pat
approved these changes
Nov 9, 2026
rad-pat
left a comment
Member
There was a problem hiding this comment.
APPROVE at dff8b92 — a pure deletion of the clean-room-review gate, its tests and its rollout tooling, matching the cleanup bullet of sc-36368. It leaves nothing dangling.
Blocking
None found.
Non-blocking
.github/workflows/test.yaml(thegatejob) — the job name "Gate regression tests" now covers onlylicense-check/test_check_licenses.py. The name is still accurate, so this is cosmetic.
Checked
- Reviewed as it would merge into origin/main at 2909825. The branch is level with the base, so there were 0 commits since the branch point and the merge is clean.
- Against sc-36368: its cleanup bullet for this repo says to delete the workflow, the
clean-room-review/folder and "thetest.yamljob that runstest_gate.sh". The PR deletes the workflow and the wholeclean-room-review/folder (test_gate.sh,rollout.sh, fixtures). Intest.yamlit removes thetest_gate.shstep but keeps thegatejob. That meets the story's intent.gatealso runspython license-check/test_check_licenses.py, which is the license-check test and unrelated to the clean-room gate. Deleting the whole job would drop that coverage, which the story does not ask for. The PR description also records that the license-check step stays. - The story asks for nothing else of this PR. The branch-protection changes and workflow disabling are done per repo and recorded on the story as applied to 85 repos. The PR makes no change outside the cleanup bullet.
- The
test.yamldiff removes only theclean-room-review/test_gate.shstep. The license-check step and the end-to-endactionjob are untouched. - At the head tree,
git grep -iforclean-roomandtest_gatefinds nothing, so nothing left here references the deleted files. - The deleted workflow triggers only on
pull_requestandpull_request_review, with noworkflow_call, so no repo can have been calling it withuses:. A code search of the PlaidCloud org for this repo's workflow path also returned no results. The other repos hold their own copies; I checked plaid's, which is standalone anddisabled_manually, and did not enumerate the rest. - Branch protection on this repo's
mainshowsrequired_approving_review_count: 1,require_last_push_approval: trueanddismiss_stale_reviews: true. That matches the description and the story's settings. I did not check the other 84 repos. - I ran no tests. CI on the head shows Test / Gate regression tests and Test / Action runs end to end both SUCCESS. The SKIPPED rows are draft-era.
🤖 Reviewed with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/plaidcloud/story/36368 (epic 36366, decision D1).
Approval is now enforced by native branch protection: 1 approval from someone other than the author, and it must come after the last push. That is applied to all 85 repos that required
clean-room-review, and the workflow is disabled in each of them. This removes the canonical copy and its tests:.github/workflows/clean-room-review.yamlclean-room-review/(test_gate.sh,rollout.sh, fixtures)test_gate.shstep intest.yaml. The license-check step stays.No repo calls this workflow via
uses:. The other repos hold disabled copies.Local gate: PASS (license-check tests and actionlint). The
action(Trivy) job only runs on GitHub.🤖 Generated with Claude Code