Skip to content

Retire clean-room-review gate (sc-36368) - #5

Merged
inviscid merged 1 commit into
mainfrom
sc-36368-retire-clean-room-review
Nov 9, 2026
Merged

inviscid merged 1 commit into
mainfrom
sc-36368-retire-clean-room-review

Conversation

@inviscid

@inviscid inviscid commented Nov 9, 2026

Copy link
Copy Markdown
Member

Story: https://app.shortcut.com/plaidcloud/story/36368 (epic 36366, decision D1).

Approval is now enforced by native branch protection: 1 approval from someone other than the author, and it must come after the last push. That is applied to all 85 repos that required clean-room-review, and the workflow is disabled in each of them. This removes the canonical copy and its tests:

  • .github/workflows/clean-room-review.yaml
  • clean-room-review/ (test_gate.sh, rollout.sh, fixtures)
  • the test_gate.sh step in test.yaml. The license-check step stays.

No repo calls this workflow via uses:. The other repos hold disabled copies.

Local gate: PASS (license-check tests and actionlint). The action (Trivy) job only runs on GitHub.

🤖 Generated with Claude Code

…on) (sc-36368)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inviscid
inviscid marked this pull request as ready for review November 9, 2026 17:21
@inviscid
inviscid requested a review from rad-pat November 9, 2026 17:21
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T17:21:51.752754Z
We couldn’t complete this review. Comment @codex review to try again.
dff8b92 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@rad-pat rad-pat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at dff8b92 — a pure deletion of the clean-room-review gate, its tests and its rollout tooling, matching the cleanup bullet of sc-36368. It leaves nothing dangling.

Blocking

None found.

Non-blocking

  1. .github/workflows/test.yaml (the gate job) — the job name "Gate regression tests" now covers only license-check/test_check_licenses.py. The name is still accurate, so this is cosmetic.

Checked

  • Reviewed as it would merge into origin/main at 2909825. The branch is level with the base, so there were 0 commits since the branch point and the merge is clean.
  • Against sc-36368: its cleanup bullet for this repo says to delete the workflow, the clean-room-review/ folder and "the test.yaml job that runs test_gate.sh". The PR deletes the workflow and the whole clean-room-review/ folder (test_gate.sh, rollout.sh, fixtures). In test.yaml it removes the test_gate.sh step but keeps the gate job. That meets the story's intent. gate also runs python license-check/test_check_licenses.py, which is the license-check test and unrelated to the clean-room gate. Deleting the whole job would drop that coverage, which the story does not ask for. The PR description also records that the license-check step stays.
  • The story asks for nothing else of this PR. The branch-protection changes and workflow disabling are done per repo and recorded on the story as applied to 85 repos. The PR makes no change outside the cleanup bullet.
  • The test.yaml diff removes only the clean-room-review/test_gate.sh step. The license-check step and the end-to-end action job are untouched.
  • At the head tree, git grep -i for clean-room and test_gate finds nothing, so nothing left here references the deleted files.
  • The deleted workflow triggers only on pull_request and pull_request_review, with no workflow_call, so no repo can have been calling it with uses:. A code search of the PlaidCloud org for this repo's workflow path also returned no results. The other repos hold their own copies; I checked plaid's, which is standalone and disabled_manually, and did not enumerate the rest.
  • Branch protection on this repo's main shows required_approving_review_count: 1, require_last_push_approval: true and dismiss_stale_reviews: true. That matches the description and the story's settings. I did not check the other 84 repos.
  • I ran no tests. CI on the head shows Test / Gate regression tests and Test / Action runs end to end both SUCCESS. The SKIPPED rows are draft-era.

🤖 Reviewed with Claude Code

@inviscid
inviscid merged commit 93084ec into main Nov 9, 2026
4 checks passed
@inviscid
inviscid deleted the sc-36368-retire-clean-room-review branch November 10, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants