Repository navigation
fix(schedule): list every page of a day's bookings on Your Bookings - #562
Merged
Merged
Conversation
The schedule read one page of GET /bookings per type and day. staff-api pages at 100 rows, and the page asks for cancelled rows too, so a user with a hundred cancelled bookings on a day could not see a live one past them. The same applied to the room-as-bookings path when app.events.use_bookings is set. Both now go through queryAllBookings, which follows the pagination the API already provides. Found by the e2e row YB-12 (bookings-limit), which fails on every fresh database.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Your Bookings read one page of
GET /bookingsper type and day. staff-api pages at 100 rows and the page asks for cancelled rows too, so a user with a hundred cancelled bookings on a day could not see a live one past them. The room-as-bookings path (app.events.use_bookings) on the same page had the same limit.Both now go through
queryAllBookings, which already follows the API's pagination (X-Total-Count, up to 50 pages) and is what the concierge reports use.Why
The e2e row YB-12 (
bookings-limiton #497) creates 105 cancelled bookings and one live one on a day and asserts the live one is listed. On any fresh database the live booking has the highest id and sits past the first page, so the row failed on every cold stack and on the runner (3 of 3 in run 38193336513).Verification
nx test bookings: 457 passed.nx test workplace: 422 passed, including a new case that two pages of a day are merged, and the visitor-filter case now stubs thequerylayer the service reads through.nx lint workplace: 0 errors (75 pre-existing warnings).nx build workplace: builds.latestimages) the YB-12 rowbookings-limitfails before this change and passes with it (9.9 s), run from the test(e2e): workplace and concierge [2026-09-18] #497 branch against a dev server built from this branch.