Skip to content

fix(place/staff_api): match transport TLS verification in placeos_client #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakach merged 1 commit into from
Oct 12, 2026
Merged

fix(place/staff_api): match transport TLS verification in placeos_client #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion drivers/place/staff_api.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,16 @@ class Place::StaffAPI < PlaceOS::Driver

# For accessing PlaceOS APIs
protected getter placeos_client : PlaceOS::Client do
insecure = setting?(Bool, :https_insecure) || setting?(String, :https_verify) == "none"
# match the driver transport: only verify certificates when https_verify sets the PEER flag
verify = case mode = setting?(String | Int32, :https_verify)
in String
{"peer", "all"}.includes?(mode.camelcase.downcase)
in Int32
mode.bits_set?(OpenSSL::SSL::VerifyMode::PEER.value)
in Nil
false
end
insecure = setting?(Bool, :https_insecure) || !verify
PlaceOS::Client.new(
@place_domain,
host_header: @host_header,
Expand Down
Loading