Skip to content

Fix Gamemode crashing the game - #3729

Open
Crepestrom wants to merge 3 commits into
PixelGuys:masterfrom
Crepestrom:fixing-gamemode-command
Open

Crepestrom wants to merge 3 commits into
PixelGuys:masterfrom
Crepestrom:fixing-gamemode-command

Conversation

@Crepestrom

Copy link
Copy Markdown
Contributor

No description provided.

@Crepestrom
Crepestrom marked this pull request as ready for review October 25, 2026 23:27
@Wunka

Wunka commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This is not the right idea. The threadcontext helps us, so that we don't change data from 2 different threads. Just setting it to something different completly breaks our assumption of what the threadContext is.

@Wunka Wunka moved this to WIP/not ready for review in PRs to review Oct 26, 2026
@Crepestrom

Copy link
Copy Markdown
Contributor Author

This is not the right idea. The threadcontext helps us, so that we don't change data from 2 different threads. Just setting it to something different completly breaks our assumption of what the threadContext is.

what do you mean
its client receive
its being received by the client
why cant it be set?

@Wunka

Wunka commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Setting it destroys all our assumptions about that every function which has a threadContext assert at the start is run on the same thread. This makes all variables that are handled in these functions vulnerable to data races.

It's not about if its a clientReceive function. Its about which thread it runs on. And the threadContext tells you that.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: WIP/not ready for review

Development

Successfully merging this pull request may close these issues.

2 participants