Repository navigation
fix(blog): match share buttons to the design - #14
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The article share block didn't match the Pencil design.
Lucide no longer ships brand icons, so X and LinkedIn are added to the existing
BrandIcon(Simple Icons paths, CC0).CopyButtongets an optionaliconprop; it still defaults tocopy, so the other places that use it don't change.Evidence
Shareis followed by a single copy icon.After: in a local build,
Shareis followed by the link, X and LinkedIn icons, measured 16px apart in the browser. Hover turns them the accent colour.Merge Danger
Door: two-way
Blast Radius: small
Changes only the article meta row. The other places that use
CopyButtonkeep the default icon.