Repository navigation
feat(blog): translation bar on untranslated posts - #13
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Untranslated posts already fall back to English, but the small inline notice was easy to miss. They now show a full-width bar under the nav with a link that opens GitHub's editor to create the missing translation.
The link goes to
github.com/PerryTS/perryts.com/new/main/src/content/blog/<slug>?filename=<lang>.md. People without write access get a fork and a pull request automatically.Evidence
All 21 posts are currently translated into all 13 locales, so no bar renders today.
building-pry/es.mdin a scratch copy and built.Result: the bar renders only on
/es/blog/building-pry/, and its link points to.../src/content/blog/building-pry?filename=es.md. Checked in a browser on desktop and at 375px; it fits on one line in both.Merge Danger
Door: two-way
Blast Radius: small
Only affects article pages for untranslated posts. Adds one
helpTranslatestring to each of the 13 locale files.