Repository navigation
test: own properties on built-in iterators keep their internal state - #13789
Merged
proggeramlug merged 2 commits intoNov 2, 2026
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
TheHypnoo
marked this pull request as ready for review
November 2, 2026 21:28
proggeramlug
deleted the
own-properties-on-built-in-iterator-objects-clob
branch
November 2, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13485.
The bug no longer reproduces on
main: built at0c427b54b0(the revision in the issue), every iterator family reports{"done":true}after an own-property write andmatchAllthrowsTypeError: RegExp operation requires an object; on currentmainthe output matches Node.This adds
test-files/test_parity_iterator_own_properties.tsso it stays fixed. It covers array/Map/Set/string/typed-array/matchAlliterators and iterator helpers (map,filter,take,drop,flatMap), with warm inline caches,delete, and enough properties to spill to overflow.0c427b54b0(exit 1, output differs from Node).main.Test-only; no
crates/change, so no changelog fragment.