Repository navigation
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7ac94c9 to
ee52cdb
Compare
ed55e0a to
744b77b
Compare
| MATCH_PREF("match-pref"), | ||
| INDUSTRY("industry"); | ||
|
|
||
| private final String cliName; |
There was a problem hiding this comment.
oh literally CLI. well this is probably not a great name, should be matchingAlgoName or something that better reflects its nature
| } | ||
| } | ||
|
|
||
| List<Member> members = MatchingMockData.activeMembers(); |
There was a problem hiding this comment.
can we modify this so that we could actually use it on a real CSV? right now it's hardcoded to this
There was a problem hiding this comment.
in general this file needs cleanup to use it for a real pairing cycle, but it's a good start and i could definitely see us using this
| System.out.println("MATCHING RUN"); | ||
| System.out.println(" Layers " + String.join(" -> ", layerNames)); | ||
| System.out.println(" Seed " + seed); | ||
| System.out.println(" Members " + memberCount + " active"); |
There was a problem hiding this comment.
would also be nice to write to a CSV
|
In general, I think this is fine to merge, even though the CLI file is unpolished. You can keep working on it to make it usable for actual matches. We also want to have some of the code you wrote in the CLI file usable when we actually do matches in the UI. Try to structure the code more so that both CLI and web flows can reuse it |
744b77b to
cad8a11
Compare
ee52cdb to
4268b6d
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
Summary
Summarize your change here. What problem does this solve or what feature does this add?
Testing
How did you test your change?
UI Changes
If your change includes a significant UI component, please attach a screenshot or video of the functionality below.