Fix Argo floats getting stuck when using local data - #400
Merged
Merged
Conversation
…cal data ingestion
erikvansebille
approved these changes
Sep 29, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good - good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents Argo Floats from getting stuck in phase 2 when using local data (i.e.
virtualship run --from-data) by mirroring the copernicusmarinecoordinates_selection_method="outside"method in_get_local_dsin base.py.Argo float simulation will now also raise an error if data is ingested with incomplete depth levels for the prescribed
max_depth, previously this was a silent bug.Also includes updates to the docs for guidance on depth levels to ensure are included when using VirtualShip with pre-downloaded/local data.
Adds tests for the replica
coordinates_selection_method="outside"method, plus for making sure the new error messaging raises.Closes #399