Document dose-response curve metrics in the schema and docs - #504
Open
jjacobson95 wants to merge 1 commit into
Open
jjacobson95 wants to merge 1 commit into
jjacobson95 wants to merge 1 commit into
Conversation
Aligns the dose-response metric descriptions with the maintainers' reference table. Updates the ResponseMetric enum descriptions in schema/coderdata.yaml (fit_auc, fit_ic50, fit_ec50, fit_ec50se, fit_einf, fit_hs, fit_r2, aac, auc, dss, mrecist, tgi) and the metric glossary on the datasets page (DSS, mRECIST, TGI, ABC, lmm), fixing placeholder text and a mislabeled mRESCIST/TG entry.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Update
#3Merge this third.
Documents the dose-response curve metrics using the maintainers' reference table, addressing #197's request for clear metric definitions in the schema and on the docs site.
Schema (schema/coderdata.yaml, ResponseMetric enum): replaced placeholder descriptions with the reference definitions for fit_auc, fit_ic50, fit_ec50, fit_ec50se, fit_einf, fit_hs, fit_r2, aac, auc, dss, mrecist, and tgi.
Docs (datasets_included.rst metric glossary): updated DSS, mRECIST (was mislabeled mRESCIST, now with the full PD/SD/PR/CR criteria), TGI (was TG), ABC, and lmm; tagged PDX-only metrics.
Verified the docs build renders the updated glossary.
Closes #197