Repository navigation
Conversation
sam3_visual_track_params duplicated 4 fields of sam3_video_params, and sam3_create_visual_tracker copied them one by one into a sam3_video_params anyway. Take sam3_video_params directly and clear text_prompt so the tracker never runs PCS detection. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M2qLmQ9ag49hT61V6i9qAq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sam3_visual_track_paramsduplicated 4 fields ofsam3_video_params(assoc_iou_threshold,max_keep_alive,recondition_every,fill_hole_area), with the same defaults.sam3_create_visual_trackerimmediately copied them field by field into asam3_video_params, because that's what the tracker stores. Now it takessam3_video_paramsdirectly and clearstext_prompt, so a visual tracker still never runs PCS detection.Public API change:
sam3_create_visual_tracker(model, sam3_video_params). The README'ssam3_create_visual_tracker(*model, {})compiles unchanged. In-repo callers are updated:examples/benchmark.cpp: changes the local's type.examples/main_video.cpp: drops the mirror struct and the 4-line copy, and passesapp.track_paramsdirectly.Behaviour: the tracker used to ignore the caller's
score_threshold,nms_thresholdandhotstart_delayand apply the defaults (0.5 / 0.1 / 15). It now honours them. Every current caller passes the defaults for those fields (main_videonever edits them), so nothing observable changes.Stacked on #20 because
tests/onmainstill uses the old struct. Merge #20 first; GitHub will retarget this PR tomain.Verification: a parity tool calls
sam3_create_visual_tracker(*model, {}), then compares add_instance plus a 3-frame propagation (and PVS) byte for byte withorigin/main:The full Release build, including
sam3_benchmarkandsam3_video, has no errors or new warnings.Follow-up worth a look:
recondition_everyis never read anywhere insam3.cpp; it's dead config insam3_video_paramstoo.git diff --shortstat: 4 files changed, 8 insertions(+), 25 deletions(-).Part of an over-engineering cleanup series.
🤖 Generated with Claude Code
https://claude.ai/code/session_01M2qLmQ9ag49hT61V6i9qAq