Repository navigation
Update GitHub action to use Checkout version 7 (checkout@v7) & msbuil… - #28
Conversation
…d version 3 (setup-msbuild@v3) Also remove specific instructions on which branches the action activates because default settings are sufficient
| push: | ||
| branches: [ main, master, '**' ] | ||
| pull_request: | ||
| branches: [ main, master ] |
There was a problem hiding this comment.
Probably good to remove the branch filter. I usually have every branch build on push.
I don't normally bother with pull_request builds. They don't tend to be super useful if there is only a single development branch open at any given time, or only one developer actively working on a project. Assuming nothing has been merged to the base branch since the current branch was opened (or last rebased), a PR build won't really differ from a branch build. Additionally the PR builds don't start until a PR is opened, which means you have to wait for builds after opening a PR, whereas branch builds start earlier and are often done by the time a PR is opened.
Edit:
Also, when there are multiple branches open or multiple active developers on a project, PR builds tend to become stale anyway, especially if review takes awhile. I find rebasing a branch and relying on branch builds to be more reliable.
2 participants
…d version 3 (setup-msbuild@v3)
Also remove specific instructions on which branches the action activates because default settings are sufficient