Repository navigation
Conversation
… is calculated - Cancel the pending route request before removing the routing control - Make a single routing request per SetDirections - Raise the Map OnError event once when routing fails (MAPS-LIB-04001) - Never leave GetTotalDistance/GetTotalDuration waiting
…utsystems-ui docs/ only holds generated TypeDoc output, so ADRs no longer need to be force-added.
gnbm
changed the title
… not awaited cleanOldFiles did not return its stream, so gulp moved on immediately and the deletion ran after the synchronous TypeScript emit, removing the freshly built files whenever dist already existed. Return the stream (aligned with outsystems-ui) so the clean finishes before the build writes into dist.
|
os-davidlourenco
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the Leaflet Directions exception when a route is removed or replaced while it is still being calculated.
What was happening
Cannot read properties of null (reading 'removeLayer')in leaflet-routing-machine: the control was removed from the map while its route request was still running.What was done
docs-internal/adrand.gitignorealigned with outsystems-ui.Test Steps
Screenshots
N/A
Checklist