Fixed Alpha/Classic Servers not showing up and added proper Server/Client filter - #26
Closed
SprainedSpark89 wants to merge 2 commits into
Closed
SprainedSpark89 wants to merge 2 commits into
SprainedSpark89 wants to merge 2 commits into
Conversation
At least it works???
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not expect this to be to be merged, it's a slapped together "fix" paired with a mostly proper fix that increases loading times by a lot. This should be used more as a guide to help with implementing a proper fix/reminder that this is an issue that exists.
What an actual proper fix would be:
A truly proper fix would be fixing the inconsistencies in the version ids between these urls which are used:
https://ornithemc.net/mc-versions/version_manifest.json
https://ornithemc.net/mc-versions/gen2/version_manifest.json
Also add entries dedicated to specifying which versions are clients and which are servers, as alpha_server and classic_server aren't enough to be able to sort with as there's versions like 1.0.1 which are server only and are release, which do not fall into one of those categories.
What I did for the filtering:
The way I have it filter causes the minecraft version list loading times to skyrocket as it's checking the details url for every single entry.