Skip to content

fix: Stronghold EntryDoor GRATES - #217

Merged
SpaceWalkerRS merged 1 commit into
OrnitheMC:gen2from
xiej2520:PR/grates
Sep 20, 2026
Merged

SpaceWalkerRS merged 1 commit into
OrnitheMC:gen2from
xiej2520:PR/grates

Conversation

@xiej2520

@xiej2520 xiej2520 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

nit, the enum name matters for StrongholdPiece serialization:

	abstract static class StrongholdPiece extends StructurePiece {
		// ...
		@Override
		protected void writeNbt(NbtCompound nbt) {
			nbt.putString("EntryDoor", this.entranceType.name());
		}
		// ...
		public static enum EntranceType {
			OPENING,
			WOOD_DOOR,
			GATES,
			IRON_DOOR;
		}

Stronghold.dat:

{
  data: {
    Features: {
      "[289,39]": {
        BB: [I;4529,8,574,4696,38,707],
        ChunkZ: 39,
        id: "Stronghold",
        Children: [
          {
            BB: [I;4626,28,626,4630,38,630],
            EntryDoor: "OPENING",
            id: "SHStart",
            GD: 0,
            Source: 1b,
            O: 3
          },
          {
            BB: [I;4631,26,623,4641,34,632],
            leftLow: 1b,
            EntryDoor: "IRON_DOOR",
            id: "SH5C",
            GD: 1,
            rightHigh: 0b,
            leftHigh: 1b,
            rightLow: 0b,
            O: 3
          },
          {
            BB: [I;4642,26,627,4648,30,631],
            Left: 0b,
            EntryDoor: "GRATES",
            Right: 0b,
            id: "SHS",
            GD: 2,
            O: 3
          },
...

@SpaceWalkerRS SpaceWalkerRS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out

@SpaceWalkerRS
SpaceWalkerRS merged commit 1e54e11 into OrnitheMC:gen2 Sep 20, 2026
0 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants