Repository navigation
analytics: report every Optable matcher in V2 prebid analytics - #376
Merged
Merged
Conversation
jplaroche
reviewed
Oct 27, 2026
jplaroche
left a comment
jplaroche
left a comment
Contributor
There was a problem hiding this comment.
Nit: it("reports LiveIntent and Optable EIDs side by side, before the source dedupe") (analytics.test.ts L469) refers to a step this PR removes. Suggest it("reports LiveIntent and Optable EIDs side by side").
jplaroche
approved these changes
Oct 27, 2026
jplaroche
left a comment
jplaroche
left a comment
Contributor
There was a problem hiding this comment.
mostly nitpicking stuff, can release without it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
V2 builds
optableMatchersfrom EIDs deduped bysource|inserter, so two Optable EIDs with the same source and different matchers report only the last matcher.What Changed
ext.eids+eidslist.optableMatchersandoptableSourceswere already unique through theirSets, so the dedupe only ever dropped matchers.How to Test
.mdalongside the code (for examplelib/addons/<addon>.md) and the matching README section. New addons ship with a new.md.Notes