Repository navigation
Ignore blank GPP values; only send IABGPP_GppSID with IABGPP_HDR_GppString - #95
Open
jrosendahl-opt wants to merge 2 commits into
Open
jrosendahl-opt wants to merge 2 commits into
jrosendahl-opt wants to merge 2 commits into
Conversation
…tring A blank (empty or whitespace-only) IABGPP_HDR_GppString, IABGPP_2_TCString or IABGPP_GppSID now counts as unset, so gpp falls back to the legacy key and the SDK never sends an empty gpp= or gpp_sid=. IABGPP_GppSID describes the CMP's own string, so it's no longer sent alongside the legacy IABGPP_2_TCString value. Mirrors Optable/optable-android-sdk#49. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ides Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #86, mirroring the fix made in Optable/optable-android-sdk#49 after review there.
Changes
IABConsentreadsIABGPP_HDR_GppString,IABGPP_2_TCStringandIABGPP_GppSIDthrough a helper that returns nil for empty or whitespace-only strings. A blankIABGPP_HDR_GppStringnow falls back to the legacy key, and the SDK never sendsgpp=orgpp_sid=.IABGPP_GppSIDonly goes withIABGPP_HDR_GppString. The CMP's section IDs describe the CMP's own string, soIABConsent.gppSidreturns nil unlessIABGPP_HDR_GppStringis set. They're no longer sent with a legacyIABGPP_2_TCStringvalue.EdgeAPI's logic is unchanged.OptableConfig.gppSiddoc now says the UserDefaults fallback applies only whengppcomes fromIABGPP_HDR_GppString.Tests
New
EdgeAPITestscases:IABGPP_GppSID = "2_7"→ legacygpp, nogpp_sidIABGPP_HDR_GppString = ""+ legacy key → legacygppIABGPP_HDR_GppStringset +IABGPP_GppSID = ""→ nogpp_sidgppFull suite passes locally on an iPhone 17 Pro simulator: 108 tests, 0 failures.
🤖 Generated with Claude Code