Repository navigation
Load demo banners on the main thread - #90
Merged
Merged
Conversation
The Swift GAM and Prebid demos loaded their banners from the targeting completion handler, which the SDK calls on a background thread. Hop to the main thread before loading, and again after Prebid's fetchDemand, as the usage guide does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
juanli16
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In the Swift demo,
GAMBannerViewControllerandPrebidBannerViewControllercallloadBanner(...)straight from thetargetingcompletion handler, which the SDK calls on a background thread. That loads the GAM banner, sets Prebid's global ORTB config and creates theBannerAdUnitoff the main thread, which UIKit and the Google Mobile Ads SDK don't allow. It also contradicts the usage guide, which tells integrators to hop to main.