Repository navigation
Document OptableTargeting, async/await and Prebid integration - #80
Merged
Merged
Conversation
Describe the OptableTargeting properties and how gamTargetingKeywords and ortb2 are derived, add the async/await variants to the Swift guide, and add a Prebid Mobile integration section to both guides based on the demo apps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosherBT
approved these changes
Oct 30, 2026
Comment on lines
+321
to
+326
| bannerAdUnit.fetchDemand(adObject: adRequest) { _ in | ||
| DispatchQueue.main.async { | ||
| bannerView.load(adRequest) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| bannerAdUnit.fetchDemand(adObject: adRequest) { _ in | |
| DispatchQueue.main.async { | |
| bannerView.load(adRequest) | |
| } | |
| } | |
| } | |
| bannerAdUnit.fetchDemand(adObject: adRequest) { [weak self] _ in | |
| DispatchQueue.main.async { | |
| self?.bannerView.load(adRequest) | |
| } | |
| } | |
| } |
mosherBT
reviewed
Oct 30, 2026
Co-authored-by: mosherBT <115997271+mosherBT@users.noreply.github.com>
Co-authored-by: mosherBT <115997271+mosherBT@users.noreply.github.com>
The fetchDemand completion kept the owning view controller alive until Prebid answered. Capture it weakly, and say up front that bannerAdUnit and bannerView are properties of the class, since the code uses self. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The guides don't describe the
OptableTargetingobject thattargeting,profileandtargetingFromCachereturn, including whatgamTargetingKeywordsandortb2contain. They don't mention the SwiftasyncAPIs either, and neither has a Prebid Mobile section, even though both demo apps integrate Prebid.Part of a series of small PRs bringing the README, guides and demo apps back in line with the code (follows #74–#79).