Repository navigation
Document hashed identifiers and normalization - #78
Merged
Merged
Conversation
Explain that email and phone values are only whitespace-stripped and lowercased before hashing (no E.164 conversion), and document passing pre-hashed values with .hem/.hashedPhoneNumber (ObjC _HEM and _HashedPhoneNumber), including validation and the double-hash pitfall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the same subsections and wording as the Swift guide, adapted to Objective-C names, so both guides describe normalization and already-hashed identifiers identically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosherBT
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a docs only PR
Neither usage guide mentions the already-hashed identifier types (
.hem/.hashedPhoneNumber, and in Objective-COptableSDKIdentifierType_HEM/_HashedPhoneNumber), so integrators who already have hashed values from their backend don't know how to send them without the SDK hashing them again.The guides also don't say how values are normalized before hashing. The SDK only removes whitespace and lowercases (
OptableIdentifierEncoder.swift). It does not convert phone numbers to E.164, so"+1 555-123-4567"and"+15551234567"hash differently and may not match the identifiers in the DCN.Part of a series of small PRs bringing the README, guides and demo apps back in line with the code (follows #74–#77).