Repository navigation
Conversation
bestzige
marked this pull request as ready for review
October 27, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing sell event fires before payment and storage removal, so listeners cannot distinguish a completed sale from one that failed. Add
SpawnerSellCompletedEventafter both steps succeed, carrying the player, location, full item quantities, and amount paid.If storage removal fails after payment, log the failure for reconciliation and do not emit the completed event. Payment and storage persistence are not atomic.
Validation:
gradlew build --no-daemonpassed. Live sale, cancelled sale, failed deposit, and failed storage removal have not been exercised.