Repository navigation
Document command structure conventions and restructure commands to match - #28
Merged
Merged
Conversation
dennis-chen-vanta
force-pushed
the
dennis-chen-vanta/cli-command-structure
branch
from
October 21, 2026 00:57
de2fdf2 to
5da4bdb
Compare
dennis-chen-vanta
added a commit
that referenced
this pull request
Oct 21, 2026
Replaces the per-command name overrides from #28's rules: - `links` in config.ts lists operations that attach or detach an existing resource; the generator names them add/remove. The spec can't mark these itself, since its summaries also say "Add" for creates. - GETs that return a file use `download`, dropping a trailing `media` segment (`trust-centers download-resource`). - `commandPlural` lets `uploads` read as `files` in list commands. - Drops the overrides that shortened names repeating the group (`list-library`, `list-deactivated`, `add-document`, `add-test`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dennis-chen-vanta
force-pushed
the
dennis-chen-vanta/cli-command-structure
branch
from
October 21, 2026 17:46
680d6c8 to
aebb6f2
Compare
Describe how REST paths map to `<group> <verb>-<noun>` commands, how inputs become flags, and where help text comes from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Flatten trust-centers, customer-trust, and knowledge-base subgroups into verb-noun commands (`trust-centers list-faqs`) - Name deep paths by joining their resources (`integrations list-resource-kind-resources`) - Name linking operations add/remove and file downloads download (`groups add-person`, `trust-centers download-resource-media`) - Make personnel-notification-settings, vendor-assessment-types, and vendor-risk-attributes top-level groups named after their paths - Add flags for spec inputs the commands didn't expose yet - Register all API groups from src/commands/index.ts Request paths are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dennis-chen-vanta
force-pushed
the
dennis-chen-vanta/cli-command-structure
branch
from
October 21, 2026 19:11
aebb6f2 to
866696d
Compare
waltonseymour
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits:
Command changes
Each line is a full command with its flags; optional flags are in
[].--page-sizeand--page-cursorare left out because they didn't change.controls(4 commands)documents(2 commands)people(1 command)personnel-notification-settings(2 commands)contracts(1 command)risk-scenarios(2 commands)vendor-assessment-types(2 commands)vendor-risk-attributes(1 command)integrations(4 commands)customer-trust(25 commands)knowledge-base(15 commands)trust-centers(78 commands)Test plan
Had agent test each command against staging with the new binary
The
add/removeanddownloadrenames and the new top-level groups were also tested by building the binary and having an isolated agent, with only the binary, run each renamed command with--dry-runand check the method and URL. Typecheck and tests (21/21) pass.🤖 Generated with Claude Code