Repository navigation
Extract reporter - #1287
Merged
Merged
Extract reporter#1287
Conversation
The technical upgrade pass can last several minutes on large collections, so a warning emitted after it could be missed by an operator checking the first log lines after upgrading, or never emitted if the process is stopped before the pass completes.
The engine accepted a reporter configuration nested under a githubIssues key and inferred its GitHub type, while the issue-reporter module expects a type next to the repositories and fails at startup without it. Moving such a configuration as is would thus prevent reporting, so the warning and the changelog give the expected shape.
Publishing to GitLab was selected by the OTA_ENGINE_GITLAB_TOKEN environment variable while all its requests authenticate with OTA_ENGINE_GITLAB_RELEASES_TOKEN. The first one was the token of the declarations repository, used by the reporter to manage issues, and the second one the token of the versions repository, where datasets are released. Publishing was first selected by the releases token, then by the declarations one when it started being used to tell that the collection is hosted on GitLab. Now that the reporter is removed, renaming OTA_ENGINE_GITLAB_TOKEN to OTA_ISSUE_REPORTER_GITLAB_TOKEN, as the migration instructions say, would silently stop publishing datasets to GitLab, while defining it without the releases token would send unauthenticated requests.
The helper that authenticates the GitLab publishing requests was moved from the reporter, whose tests covered it, into the publisher, whose tests did not check the authorization header. A request sent without the releases token would thus have left the tests passing while failing on GitLab.
The GitLab publisher read only the uppercase proxy environment variables, while the fetcher also honours the lowercase ones that the environment example presents as alternatives. With only HTTP_PROXY defined, it also reached the HTTPS API with an agent that does not tunnel, which fails. Resolving the proxies as the fetcher does and choosing the agent from the scheme of the API publishes the dataset through the same proxy as the terms are fetched.
clementbiron
approved these changes
Oct 8, 2026
clementbiron
added a commit
to OpenTermsArchive/docs
that referenced
this pull request
Oct 8, 2026
Renaming `OTA_ENGINE_GITHUB_TOKEN` would remove the token the engine still uses to publish datasets to GitHub releases, which contradicted the following sentence. On GitLab, the engine now publishes datasets with `OTA_ENGINE_GITLAB_RELEASES_TOKEN` only, so `OTA_ENGINE_GITLAB_TOKEN` can be renamed, as described in OpenTermsArchive/engine#1287.
clementbiron
added a commit
to OpenTermsArchive/docs
that referenced
this pull request
Oct 8, 2026
The engine selected GitLab publishing with `OTA_ENGINE_GITLAB_TOKEN` while authenticating every request with `OTA_ENGINE_GITLAB_RELEASES_TOKEN`. Since OpenTermsArchive/engine#1287, publishing depends on the releases token only and `OTA_ENGINE_GITLAB_TOKEN` is no longer used.
clementbiron
added a commit
to OpenTermsArchive/docs
that referenced
this pull request
Oct 8, 2026
Since OpenTermsArchive/engine#1287, the GitLab dataset publisher resolves the proxy as the fetcher does, so the proxy variables also apply to dataset publishing. Both also honour the lowercase variables, which take precedence over the uppercase ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.