Skip to content

Fix accessibility and robustness findings from the branch review (develop) - #234

Merged
mlaetitia merged 2 commits into
developfrom
fix/t51eng-2081-review-findings-develop
Sep 7, 2026
Merged

Fix accessibility and robustness findings from the branch review (develop)#234
mlaetitia merged 2 commits into
developfrom
fix/t51eng-2081-review-findings-develop

Conversation

@mlaetitia

@mlaetitia mlaetitia commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Related to #

Proposed changes

  • Escape closes a mega menu panel from inside it, and closes one opened by hover.
  • Green text and the mobile CTA use the darker brand preset so they meet WCAG AA contrast.
  • Placeholder submenu links are only click-blocked on desktop, so mobile accordion rows respond to taps.
  • The mobile caret is centred on its row.
  • The featured card's link darkens on hover instead of lightening.
  • aria-haspopup removed from the panel triggers.
  • The nav_menu_link_attributes callback no longer declares typed parameters.

Why are these changes being made?

Findings from a review of the branch, each reproduced before the fix and re-checked after.

  • Escape only closed a panel when focus was already on the trigger, and never closed one opened by hover.
  • Green text and the mobile CTA failed AA contrast at 3.13:1 on white.
  • Tapping a mobile row's label did not expand it; only the caret worked.
  • The mobile caret sat 5px below the centre of its row.
  • Hovering the featured card's link made it lighter than its resting colour instead of darker.
  • aria-haspopup="true" promised screen reader users arrow-key menu navigation this component does not implement.
  • The nav_menu_link_attributes callback declared typed parameters, which would fatal any page rendering a menu through a plugin's walker.

Testing instructions

Above 1200px:

  • Tab into a dropdown item, move into the panel, then press Escape from a link inside it. The panel should close and focus should return to the top-level item.
  • Hover a dropdown open, do not move the pointer, press Escape. The panel and the dimmed background should both go. Moving away and back should reopen it normally.
  • The eyebrow, the featured card's heading and its link should read as a deeper green. Hovering the link should darken it further and underline it.
  • Panels should still open on hover and on keyboard focus, and columns should still fill top to bottom before wrapping.

Below 1200px:

  • Tap a top-level row on the label rather than the caret. It should expand.
  • The caret should sit level with the row's text, both collapsed and expanded.
  • The Get Involved button should be a deeper green with white text.

Screen reader, if convenient: top-level items should announce as collapsed or expanded, and no longer as a menu popup.

mlaetitia and others added 2 commits September 7, 2026 17:08
…ion taps and a filter signature that could fatal

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
… on its row, and let the featured link's hover win over the generic submenu rule

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
@mlaetitia
mlaetitia merged commit d2a0426 into develop Sep 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant