Fix accessibility and robustness findings from the branch review (develop) - #234
Merged
Merged
Conversation
…ion taps and a filter signature that could fatal Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
… on its row, and let the featured link's hover win over the generic submenu rule Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Proposed changes
aria-haspopupremoved from the panel triggers.nav_menu_link_attributescallback no longer declares typed parameters.Why are these changes being made?
Findings from a review of the branch, each reproduced before the fix and re-checked after.
aria-haspopup="true"promised screen reader users arrow-key menu navigation this component does not implement.nav_menu_link_attributescallback declared typed parameters, which would fatal any page rendering a menu through a plugin's walker.Testing instructions
Above 1200px:
Below 1200px:
Screen reader, if convenient: top-level items should announce as collapsed or expanded, and no longer as a menu popup.