check gmtime_r return in httpGetDateString - #167
Closed
tanjiroK-coder wants to merge 1 commit into
Closed
tanjiroK-coder wants to merge 1 commit into
tanjiroK-coder wants to merge 1 commit into
Conversation
michaelrsweet
added a commit
that referenced
this pull request
Sep 26, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpGetDateStringtakes atime_tstraight from the caller and feeds it togmtime_rwithout checking the result. When the value falls outside the rangegmtime_rcan represent it returnsNULLand leavestdateuntouched, and the code then usestdate.tm_wdayandtdate.tm_monas indices into the 7- and 12-elementhttp_days/http_monthstables and hands the loaded pointer to%s, so an uninitialisedtm_monbecomes an out-of-bounds read and a wild pointer dereference. The reachable path iscups-oauth, which passes(time_t)cupsJSONGetNumber(value)from a JWTexp/iat/nbfclaim, so an id_token carryingexp: 9e18is enough. I hit it reading the code afterbb7b1e5and confirmedgmtime_rreturnsNULLthere; a build against the sanitiser faults with a SEGV insidehttpGetDateStringon that input. This is the same fixbb7b1e5applied to the siblingippTimeToDate, so I mirrored it here: zero the struct and settm_mdayto 1 whengmtime_rfails.Assisted-by: Claude Code:Opus-4.8 [Claude Code]