Skip to content

created brand TM3D - #325

Open
Elronvr wants to merge 4 commits into
OpenPrintTag:main-prfrom
Elronvr:main-pr
Open

Elronvr wants to merge 4 commits into
OpenPrintTag:main-prfrom
Elronvr:main-pr

Conversation

@Elronvr

@Elronvr Elronvr commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

added all basic PLA materials, added all 1kg packages, added 1kg filaron spool
include spool dimensions
included temperature ranges
included gtins for packages
changes validate locally without errors

@ondratu

ondratu commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Hi @Elronvr, thank you for the contribution and for adding the whole TM3D PLA range! Validation passes locally, so the structure looks good. I have two small things before this can be merged:

  1. Duplicate GTIN – 6013915323359 is used by two different packages:

    • data/material-packages/tm3d/tm3d-pla-broken-white-tm3d-spool-1kg.yaml
    • data/material-packages/tm3d/tm3d-pla-glow-in-the-dark-tm3d-spool-1kg.yaml

    A GTIN should be unique per product, so one of them is probably a copy/paste slip. Could you please check the correct code on the packaging or the e-shop and fix it? If you can't find it, it is fine to leave gtin out for that package.

  2. Missing package – the material tm3d-pla-light-grey exists, but there is no matching data/material-packages/tm3d/tm3d-pla-light-grey-tm3d-spool-1kg.yaml. Could you please add it (or let us know if the 1 kg spool is not sold in this colour)?

Thanks again for your work!

@Elronvr

Elronvr commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ondratu i checked and the glow in the dark indeed had a incorrect gtin, this has been corrected. the uuid is also regenerated to reflect this change. the light grey package has also been added as this indeed also exists in a 1kg package

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants