You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
added all basic PLA materials, added all 1kg packages, added 1kg filaron spool
include spool dimensions
included temperature ranges
included gtins for packages
changes validate locally without errors
Hi @Elronvr, thank you for the contribution and for adding the whole TM3D PLA range! Validation passes locally, so the structure looks good. I have two small things before this can be merged:
Duplicate GTIN – 6013915323359 is used by two different packages:
A GTIN should be unique per product, so one of them is probably a copy/paste slip. Could you please check the correct code on the packaging or the e-shop and fix it? If you can't find it, it is fine to leave gtin out for that package.
Missing package – the material tm3d-pla-light-grey exists, but there is no matching data/material-packages/tm3d/tm3d-pla-light-grey-tm3d-spool-1kg.yaml. Could you please add it (or let us know if the 1 kg spool is not sold in this colour)?
Hi @ondratu i checked and the glow in the dark indeed had a incorrect gtin, this has been corrected. the uuid is also regenerated to reflect this change. the light grey package has also been added as this indeed also exists in a 1kg package
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added all basic PLA materials, added all 1kg packages, added 1kg filaron spool
include spool dimensions
included temperature ranges
included gtins for packages
changes validate locally without errors